HBASE-29531 Migrate RegionServer Status Jamon page back to JSP by PDavid · Pull Request #7371 · apache/hbase

PDavid · 2025-10-08T14:23:58Z

ℹ️ Sorry, this PR is also quite large and I did not found a way to make it smaller. Maybe it is better to check the changes commit-by-commit.

This is the 2/3 step of the Jamon to JSP migration: the Region Server Status page.

Did the migration the same way as for the Master Status page: #6875

Migrated the Jamon code to JSP as close as possible. Extracted the duplicated formatZKString method to new java class: ZKUtil and added unit tests.

Changed the Region Server Status page back to /regionserver.jsp. Made sure that /rs-status redirects to /regionserver.jsp.

Extracted the BlockCache inline CSS styles to hbase.css file. Also extracted the large BlockCache Hit Ratio periods paging JavaScript code to separate .js file.

Introduced a src/main/resources/hbase-webapps/common directory where we can place common JSP files which are used by both Master and RegionServer JSP pages. This required to adjust the JSP compiler Maven Antrun plugin a bit.

Extracted the inline tablesorter initialization JavaScript code to separate file.

Also fix content-type of master JSON task view.

Also share formatZKString method with Master Status page.

to satisfy checkstyle.

to fix rubocop violation about the lines being too long.

PDavid · 2025-10-09T15:07:43Z

I tested this locally in standalone mode after building with Maven (mvn clean install -DskipTests && bin/start-hbase.sh). I created some tables, adding data with the ltt tool (bin/hbase ltt -num_keys 10000 -write 100:100 -num_tables 10 -multiput)

Also configured BlockCache accordiong to the example configuration https://hbase.apache.org/book.html#bc.example

conf/hbase-env.sh:
...
export HBASE_HEAPSIZE=5G
...

conf/hbase-site.xml:
...
  <property>
    <name>hbase.bucketcache.ioengine</name>
    <value>offheap</value>
  </property>
  <property>
    <name>hfile.block.cache.size</name>
    <value>0.2</value>
  </property>
  <property>
    <name>hbase.bucketcache.size</name>
    <value>4196</value>
  </property>
...

and checked the RS status page if the Block Cache details and the Hit ration periods are properly displayed:

Apache9

Let's get this in first.

hbase-server/src/main/java/org/apache/hadoop/hbase/util/ZKUtil.java

We already had another ZKUtil.

Apache-HBase · 2025-10-13T08:08:49Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 29s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+0 🆗	jshint	0m 1s		jshint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+0 🆗	mvndep	0m 34s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 29s		master passed
+1 💚	compile	3m 42s		master passed
+1 💚	checkstyle	0m 45s		master passed
+1 💚	spotbugs	1m 38s		master passed
+1 💚	spotless	0m 45s		branch has no errors when running spotless:check.
-0 ⚠️	patch	0m 58s		Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 11s		the patch passed
+1 💚	compile	3m 51s		the patch passed
+1 💚	javac	3m 51s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 37s		hbase-server: The patch generated 0 new + 0 unchanged - 4 fixed = 0 total (was 4)
+1 💚	checkstyle	0m 8s		The patch passed checkstyle in hbase-shell
-0 ⚠️	rubocop	0m 10s	/results-rubocop.txt	The patch generated 1 new + 84 unchanged - 1 fixed = 85 total (was 85)
+1 💚	xmllint	0m 0s		No new issues.
+1 💚	spotbugs	1m 46s		the patch passed
+1 💚	hadoopcheck	12m 23s		Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 💚	spotless	0m 46s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 17s		The patch does not generate ASF License warnings.
		42m 43s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7371/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#7371
Optional Tests	dupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile spotbugs checkstyle hbaseanti jshint rubocop
uname	Linux dcaf2498a661 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `188f039`
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	85 (vs. ulimit of 30000)
modules	C: hbase-server hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7371/3/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3 rubocop=1.37.1 xmllint=20913
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2025-10-13T12:06:46Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 28s		Docker mode activated.
-0 ⚠️	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+0 🆗	mvndep	0m 19s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 22s		master passed
+1 💚	compile	1m 12s		master passed
+1 💚	javadoc	0m 39s		master passed
+1 💚	shadedjars	6m 9s		branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	patch	6m 26s		Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 58s		the patch passed
+1 💚	compile	1m 13s		the patch passed
+1 💚	javac	1m 13s		the patch passed
+1 💚	javadoc	0m 38s		the patch passed
+1 💚	shadedjars	6m 2s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	243m 26s		hbase-server in the patch passed.
+1 💚	unit	8m 5s		hbase-shell in the patch passed.
		280m 40s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7371/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#7371
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 02d790886e7b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `188f039`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7371/3/testReport/
Max. process+thread count	3466 (vs. ulimit of 30000)
modules	C: hbase-server hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7371/3/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

This is the 2/3 step of the Jamon to JSP migration: the Region Server Status page. Did the migration the same way as for the Master Status page: #6875 Migrated the Jamon code to JSP as close as possible. Extracted the duplicated `formatZKString` method to new java class: ZKStringFormatter and added unit tests. Changed the Region Server Status page back to `/regionserver.jsp`. Made sure that `/rs-status` redirects to `/regionserver.jsp`. Extracted the BlockCache inline CSS styles to `hbase.css` file. Also extracted the large BlockCache Hit Ratio periods paging JavaScript code to separate .js file. Introduced a `src/main/resources/hbase-webapps/common` directory where we can place common JSP files which are used by both Master and RegionServer JSP pages. This required to adjust the JSP compiler Maven Antrun plugin a bit. Extracted the inline tablesorter initialization JavaScript code to separate file. Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit 7892207)

* HBASE-29531 Migrate RegionServer Status Jamon page back to JSP (#7371) This is the 2/3 step of the Jamon to JSP migration: the Region Server Status page. Did the migration the same way as for the Master Status page: #6875 Migrated the Jamon code to JSP as close as possible. Extracted the duplicated `formatZKString` method to new java class: ZKStringFormatter and added unit tests. Changed the Region Server Status page back to `/regionserver.jsp`. Made sure that `/rs-status` redirects to `/regionserver.jsp`. Extracted the BlockCache inline CSS styles to `hbase.css` file. Also extracted the large BlockCache Hit Ratio periods paging JavaScript code to separate .js file. Introduced a `src/main/resources/hbase-webapps/common` directory where we can place common JSP files which are used by both Master and RegionServer JSP pages. This required to adjust the JSP compiler Maven Antrun plugin a bit. Extracted the inline tablesorter initialization JavaScript code to separate file. Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit 7892207) * [ADDENDUM] HBASE-29223 Fix TestMasterStatusUtil (#7416) TestMasterStatusUtil.testGetFragmentationInfoTurnedOn failed in master nightly build Signed-off-by: Nihal Jain <nihaljain@apache.org> Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit 8ef271f)

…e#7371) This is the 2/3 step of the Jamon to JSP migration: the Region Server Status page. Did the migration the same way as for the Master Status page: apache#6875 Migrated the Jamon code to JSP as close as possible. Extracted the duplicated `formatZKString` method to new java class: ZKStringFormatter and added unit tests. Changed the Region Server Status page back to `/regionserver.jsp`. Made sure that `/rs-status` redirects to `/regionserver.jsp`. Extracted the BlockCache inline CSS styles to `hbase.css` file. Also extracted the large BlockCache Hit Ratio periods paging JavaScript code to separate .js file. Introduced a `src/main/resources/hbase-webapps/common` directory where we can place common JSP files which are used by both Master and RegionServer JSP pages. This required to adjust the JSP compiler Maven Antrun plugin a bit. Extracted the inline tablesorter initialization JavaScript code to separate file. Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit 7892207)

#7505) This is the 2/3 step of the Jamon to JSP migration: the Region Server Status page. Did the migration the same way as for the Master Status page: #6875 Migrated the Jamon code to JSP as close as possible. Extracted the duplicated `formatZKString` method to new java class: ZKStringFormatter and added unit tests. Changed the Region Server Status page back to `/regionserver.jsp`. Made sure that `/rs-status` redirects to `/regionserver.jsp`. Extracted the BlockCache inline CSS styles to `hbase.css` file. Also extracted the large BlockCache Hit Ratio periods paging JavaScript code to separate .js file. Introduced a `src/main/resources/hbase-webapps/common` directory where we can place common JSP files which are used by both Master and RegionServer JSP pages. This required to adjust the JSP compiler Maven Antrun plugin a bit. Extracted the inline tablesorter initialization JavaScript code to separate file. (cherry picked from commit 7892207) Signed-off-by: Duo Zhang <zhangduo@apache.org>

* HBASE-29531 Migrate RegionServer Status Jamon page back to JSP (#7371) This is the 2/3 step of the Jamon to JSP migration: the Region Server Status page. Did the migration the same way as for the Master Status page: #6875 Migrated the Jamon code to JSP as close as possible. Extracted the duplicated `formatZKString` method to new java class: ZKStringFormatter and added unit tests. Changed the Region Server Status page back to `/regionserver.jsp`. Made sure that `/rs-status` redirects to `/regionserver.jsp`. Introduced a `src/main/resources/hbase-webapps/common` directory where we can place common JSP files which are used by both Master and RegionServer JSP pages. This required to adjust the JSP compiler Maven Antrun plugin a bit. Extracted the inline tablesorter initialization JavaScript code to separate file. Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit 7892207) * HBASE-29531 Fix missing charset in RS Status page Made sure that the Content-Type HTTP header includes the UTF-8 charset when the RegionServer status web UI page is returned so that it is consistent with Master Status web UI page. --------- Signed-off-by: Duo Zhang <zhangduo@apache.org>

PDavid added 13 commits October 8, 2025 13:19

HBASE-29531 Migrate RegionServer Status Jamon page back to JSP

b5635eb

HBASE-29531 BlockCache

9a11397

HBASE-29531 BlockCache view, reuse common JSP-s, TaskMonitor

b9ebdc9

Also fix content-type of master JSON task view.

HBASE-29531 Region list

461b2e3

HBASE-29531 Region Server Status page scripts

625daa5

HBASE-29531 Replication Status

c03d887

HBASE-29531 Software Attributes section

9f9c0d1

Also share formatZKString method with Master Status page.

HBASE-29531 Remove RegionServer Status related Jamon files

a59d179

HBASE-29531 Remove TaskMonitorTmpl.jamon previously shared Jamon file

cb524a4

HBASE-29531 Change links from /rs-status to /regionserver.jsp

85b2160

HBASE-29531 Added tests for the Region Status page

79c3f59

HBASE-29531 Extracted inline Strings to constants

16c900a

HBASE-29531 Added unit tests ZKUtil.formatZKString

389890a

PDavid self-assigned this Oct 8, 2025

This comment has been minimized.

Sign in to view

PDavid added 3 commits October 9, 2025 11:01

HBASE-29531 Changed RSStatusConstants and ZKUtil to final class

4e0a43b

to satisfy checkstyle.

HBASE-29531 Extracted regionserver path in taskmonitor.rb

ec76540

to fix rubocop violation about the lines being too long.

HBASE-29531 Fixed TestRSStatusPage content type includes encoding

4c6972c

This comment has been minimized.

Sign in to view

PDavid marked this pull request as ready for review October 9, 2025 14:29

PDavid requested a review from stoty October 9, 2025 15:27

Apache9 approved these changes Oct 10, 2025

View reviewed changes

hbase-server/src/main/java/org/apache/hadoop/hbase/util/ZKUtil.java Outdated Show resolved Hide resolved

HBASE-29531 Renamed ZKUtil to ZKStringFormatter

188f039

We already had another ZKUtil.

PDavid merged commit 7892207 into apache:master Oct 16, 2025
1 check passed

PDavid deleted the HBASE-29531-jamon-jsp-rsstatus branch October 16, 2025 08:11

PDavid mentioned this pull request Oct 16, 2025

HBASE-29596 Migrate Canary Status Jamon page back to JSP #7390

Merged

This was referenced Dec 1, 2025

HBASE-29531 Migrate RegionServer Status Jamon page back to JSP #7491

Merged

HBASE-29531 Migrate RegionServer Status Jamon page back to JSP #7492

Merged

PDavid mentioned this pull request Dec 3, 2025

HBASE-29531 Migrate RegionServer Status Jamon page back to JSP #7505

Merged

PDavid mentioned this pull request Jan 5, 2026

HBASE-29531 Migrate RegionServer Status Jamon page back to JSP #7590

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-29531 Migrate RegionServer Status Jamon page back to JSP#7371

HBASE-29531 Migrate RegionServer Status Jamon page back to JSP#7371
PDavid merged 17 commits intoapache:masterfrom
PDavid:HBASE-29531-jamon-jsp-rsstatus

PDavid commented Oct 8, 2025 •

edited

Loading

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

PDavid commented Oct 9, 2025

Uh oh!

Apache9 left a comment

Uh oh!

Uh oh!

Apache-HBase commented Oct 13, 2025

Uh oh!

Apache-HBase commented Oct 13, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

PDavid commented Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

PDavid commented Oct 9, 2025

Uh oh!

Apache9 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Apache-HBase commented Oct 13, 2025

Uh oh!

Apache-HBase commented Oct 13, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

PDavid commented Oct 8, 2025 •

edited

Loading